Re: #1290: Add sign and verify CLI commands #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Feb 26, 2020
|
IMO sign and verify should be taking in files (and stdin as an option/default). |
arajasek
force-pushed
the
asr/clisign
branch
from
f8262cd to
ec38202
Compare
arajasek
commented
Feb 26, 2020
Thanks for the review, @Kubuxu!
|
arajasek
force-pushed
the
asr/clisign
branch
from
ec38202 to
37b3ce8
Compare
|
@magik6k Implemented and tested the custom error, the error log is now set to |
- The command takes an address and a message (in hex) and prints out a signature of the msg
- The command takes an address, message, and signature, and returns true if the sig is valid
arajasek
force-pushed
the
asr/clisign
branch
from
37b3ce8 to
fe8db29
Compare
magik6k
approved these changes
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically as in #1290. Usage is as follows:
lotus wallet sign <msg>signs<msg>with the wallet's default accountlotus wallet sign --from <addr> <msg>signs withlotus waller verify <addr> <msg> <sigBytes>prints "Valid" if is a valid signature of by , else prints "Invalid"